Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Jun 1, 2016

This pull adds build/build.css to the module, so the compiled css can be distributed. fixes #190

@pvnr0082t can you check over the PR and make sure it's what you need?

cc @mdo

@pvnr0082t
Copy link

@PeterDaveHello I don't know how to check it. Could you please help me? It seems that prebuilt file would be added back.

@PeterDaveHello
Copy link

Looks fine, @pvnr0082t you can just pull this change and try to run it.

@pvnr0082t
Copy link

@jonrohan It's great. Thank you.

@jonrohan
Copy link
Member Author

jonrohan commented Jun 2, 2016

Sorry to hold this up, but I don't feel great about checking build/build.css into the repo. But I just learned how to include this file in the npm package. Not knowing much about cdnjs, does it grab the package from npmjs? If it does, I'd love to instead of this way, setup the repository to include the build in the published version.

With this PR #193 I added the build/build.css to the npm registry, @pvnr0082t can you double check that works for you?

@jonrohan
Copy link
Member Author

jonrohan commented Jun 2, 2016

That's primer-css@4.0.2

@pvnr0082t
Copy link

@jonrohan Yes, that's really nice. Thanks for your big help.

@jonrohan jonrohan closed this Jun 2, 2016
@jonrohan jonrohan deleted the add_built_css branch June 3, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no prebuilt file in npm package

4 participants